Skip to content

[ALICE3] Add digitization for the forward tracker - #15620

Merged
shahor02 merged 8 commits into
AliceO2Group:devfrom
marcovanleeuwen:dev
Jul 29, 2026
Merged

[ALICE3] Add digitization for the forward tracker#15620
shahor02 merged 8 commits into
AliceO2Group:devfrom
marcovanleeuwen:dev

Conversation

@marcovanleeuwen

@marcovanleeuwen marcovanleeuwen commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Merge ALICE3 FT3 into TRK and add digitisation for the forward disks.

@alibuild alibuild mentioned this pull request Jul 22, 2026
Merged
@njacazio
njacazio enabled auto-merge (squash) July 22, 2026 13:53
njacazio
njacazio previously approved these changes Jul 22, 2026
View reviewed changes
@marcovanleeuwen

marcovanleeuwen commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Hi all,

I checked the error messages in validation and they seem to be unrelated to my commits. In the build/SLC, there is the following:

Could not find the DPL InfoLogger

while in the arm build, there is an error in the simulation test for the (run 2) muon ID:

Detectors/MUON/MID/Simulation/test/testSimulation.cxx 
....
Warning: no efficiency found for deId: 20  column: 6  line: 4  type: 0
Warning: no efficiency found for deId: 20  column: 6  line: 4  type: 2
Warning: no efficiency found for deId: 20  column: 6  line: 4  type: 1
/sw/SOURCES/O2/slc9_aarch64-slc9_aarch64/0/Detectors/MUON/MID/Simulation/test/testSimulation.cxx(492): �[1;31;49merror: in "o2_mid_simulation/MID_SimClusters/_5": check sortedPC.size() == 1 has failed [0 != 1]
Failure occurred in a following context:
    deId = 20; �[0;39;49m
/sw/SOURCES/O2/slc9_aarch64-slc9_aarch64/0/Detectors/MUON/MID/Simulation/test/testSimulation.cxx(494): �[1;31;49merror: in "o2_mid_simulation/MID_SimClusters/_5": Point: (112.816, -36.1202)  outside PC:
Failure occurred in a following context:
    deId = 20; �[0;39;49m

Is there something that I should still check, or can we move on with the merge?

Best regards, Marco.

@alibuild

alibuild commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 37625d6 at 2026-07-24 18:03:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/base/src/GeometryTGeo.cxx:174:31: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/base/src/GeometryTGeo.cxx:741:24: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@marcovanleeuwen

marcovanleeuwen commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

The latest compilation/test on aarch failed with

8975:internal-dpl-injected-dummy-sink]: [23:26:21][STATE] Exiting FairMQ state machine
[8975:internal-dpl-injected-dummy-sink]: [23:26:21][FATAL] error while setting up workflow in o2-raw-file-reader-workflow: 1 of the binding channels could not initialize. Initial configuration incomplete.
[8975:internal-dpl-injected-dummy-sink]: terminate called after throwing an instance of 'o2::framework::RuntimeErrorRef'
[8975:internal-dpl-injected-dummy-sink]: *** Program crashed (Aborted)
[8975:internal-dpl-injected-dummy-sink]: Backtrace by DPL:
[8975:internal-dpl-injected-dummy-sink]: Executable is /sw/slc9_aarch64/O2/slc9_aarch64-slc9_aarch64-local22/bin/o2-raw-file-reader-workflow

which as far as I can tell is unrelated to my changes.

@njacazio

njacazio commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Hi @shahor02 could you please have a look? Thanks!

shahor02
shahor02 approved these changes Jul 28, 2026
View reviewed changes

@shahor02 shahor02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but it is 40 commits behind the dev, particularly, I don't see my fix to this digitizer https://github.com/AliceO2Group/AliceO2/pull/15606/changes
It will likely apply cleanly, but could you rebase it before merging?

@marcovanleeuwen
Rebase to dev
6b65f7d 
Rebase to dev
@shahor02
shahor02 disabled auto-merge July 29, 2026 17:23
@shahor02
shahor02 merged commit 3f13a59 into AliceO2Group:dev Jul 29, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes
@shahor02 shahor02 shahor02 approved these changes
@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner
@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcovanleeuwen @alibuild @njacazio @shahor02